test naming
Wouter van Heyst
larstiq at larstiq.dyndns.org
Wed Nov 23 23:33:38 GMT 2005
On Thu, Nov 24, 2005 at 08:58:00AM +1100, Robert Collins wrote:
> On Wed, 2005-11-23 at 09:49 -0600, John A Meinel wrote:
>
> > I went ahead and did this, since you are sleeping now. In my integration
> > branch, all of the tests are now named:
> > bzrlib/tests/test_foo.py
> >
> > I went with the underscore, because I thought not having it looked bad,
> > especially for something like: testcommit_merge.py
> >
> > Everything has been consistently named now. And all 493 tests run and pass.
> >
> > I changed the name to "tests" because selftest was a remnant left over
> > because of the command name. While 'tests' fits better (and is shorter).
>
> so PEP8 says it should be testcommitmerge.py not test_commitmerge.py or
> testcommit_merge.py or test_commit_merge.py. I'm pretty sure we have a
> not on this in HACKING.
If you mean the 'Writing tests' section in HACKING, I thought that was
the bit up for discussion. In PEP8 I only see a mention of module
naming, but I'm not confident in applying it like this.
Wouter
More information about the bazaar
mailing list