[PATCH] FTP transport

[Matthieu Moy]

Daniel Silverstone <dsilvers at digital-scurf.org> writes:

> In an attempt to solve one of the BzrAdoptionBlockers I implemented an
> ftp:// transport today.

Cool!

> I'd appreciate comments/bug reports etc

It seems to open a new ftp connection for each operation.

$ strace -f bzr push ftp://<login>:<password>@ftpperso.free.fr/bzr.dev |& grep -e <login> -e ftpperso.free.fr
[...]
execve("/usr/bin/python2.4", ["python2.4", "/home/moy/bin/bzr", "push", "ftp://<login>:<password>@ftpp"...], [/* 64 vars */]) = 0
send(4, "USER <login>\r\n", 19, 0) = 19
recv(4, "230 User <login> logged in."..., 8192, 0) = 34
send(5, "USER <login>\r\n", 19, 0) = 19
recv(5, "230 User <login> logged in."..., 8192, 0) = 34
send(6, "USER <login>\r\n", 19, 0) = 19
$

It isn't optimal performance-wise. But worse than this, my provider
just answers:

bzr: ERROR: bzrlib.transport.ftp.FtpTransportError: Error setting up connection: 530 Sorry, the maximum number of clients (2) for this user are already connected.
  at /net/ecrins/local/moy/usr/src/bzr.dev/bzrlib/transport/ftp.py line 98
  in _get_FTP

(it did create the bzr.dev directory, but it's empty)

(I don't know whether this comes from the transport layer of from
ftp.py itself, though)

-- 
Matthieu