please check out weave-format branch

[John Arbash Meinel]

Martin Pool wrote:
> Hi,
> 
> My branch using the weave format is just about ready for adoption.  If
> you would like a copy you can either pull or rsync from
> http://bazaar-ng.org/bzr/bzr.newformat, or get this tarball:
> 
>   http://bazaar-ng.org/pkg/snapshot/bzr-0.1pre-1374.tgz
> 
> As test data, a copy of the bzr history converted to weaves is here:
> 
>   http://bazaar-ng.org/pkg/snapshot/bzr.newformat.asweaves-20050922.tgz
> 
> (The uncompressed history size shrunk from 101MB to 6.8MB).
> 
> Existing branches can be converted using the 'tools/history2weaves.py'
> script (which should be changed to run from the upgrade command.) 
> This upgrades a branch in place; make a copy first.
> 
> --
> Martin
> 
> 

I'm looking through the new revision and inventory XML, (though it is a
little tricky to parse through the weaves, at least they are text :).

Is there a simple command to say "give me this version of the
inventory.weave file"?

Anyway, in looking through it, I had some questions about the new
format. I originally wrote this as one big email, but probably it should
spawn new threads, so I'll break it down:

1) inventories now have a "text_version" and a "name_version". I assume
you are storing the last changed version for the name and the last
changed version for the text. Is this really necessary? Are you trying
to make it so that you don't need to add a new entry to the weave file
if only the name changes? Is it expensive to add a new version with
identical contents? Not a big deal, though. I'm guessing your method is
just fine.

2) Is it really that difficult to have bzr.newformat support the
oldformat? All you have to do is detect it from .bzr/branch-format, and
then create the old stores, etc. (I'm not sure what else you changed in
the code, though.) It looks like you are doing the check, but rely on
"relax_version_check" which is probably only set by the upgrade code.
>From what I've seen, the new code might depend on things like the
ancestry file, so it might be required.


John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050922/c78e7265/attachment.pgp