[PATCH]: Optional explanation for options

Rob Browning rlb at defaultvalue.org
Tue Sep 20 17:58:12 BST 2005


John A Meinel <john at arbash-meinel.com> writes:

> Martin Pool wrote:

>>  + we can check the diff is plausible (perhaps modulo whitespace)
>> compared to the result of applying the binary change
>
> I would put this as a "-" rather than a plus, since you need to do the
> check. And I think it is a genuine weakness, since you are handwaving
> some text, and then actually applying what is in the binary blob. So
> what the human reviews is only close to what actually gets applied.

I agree.  This seems like it just means duplicated review work.

No matter how carefully you review the "readable diff", you'll still
need to do the exact same work to evaluate the result of applying the
binary blob.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4




More information about the bazaar mailing list