[PATCH]: Optional explanation for options

Jan Hudec bulb at ucw.cz
Tue Sep 20 08:27:18 BST 2005


On Tue, Sep 20, 2005 at 14:47:00 +1000, Martin Pool wrote:
> On 20/09/05, John A Meinel <john at arbash-meinel.com> wrote:
> 
> > Well, the current changeset code does verify that all of the hashes are
> > correct. But since we don't transmit the text hashes, it only figures it
> > out once it has generated the inventory, which also means that it can't
> > figure out which file is bogus, just that something is.
> 
> Another approach, which lifeless has advocated, is to transmit the
> actual changes as a binary blob attached to the message, and a
> human-readable diff just as a summary.  This has some strengths and
> weaknesses:
> 
>  + does not require submitter to have published a public branch
>  + no chance of whitespace mangling
>  + can (optionally) compactly include a whole series of intermediate
> revisions, as well as the final result
>  + can include gpg signatures for revisions, with no chance of them
> being damaged
>  + the human readable diff doesn't need to show any ids or hashes
>  + can patch binary or non-ascii files
>  + we can check the diff is plausible (perhaps modulo whitespace)
> compared to the result of applying the binary change
>  - some people would find the attachment ugly

SVK does a diff with a base64 blob at the end. Perhaps bazaar could use
some similar approach -- use normal diff chunks for text files,
base64-encoded binary diff chunks for binary files and a blob of base64
data with the signatures, checksums and such. They could be just pickle
dump of the data.

--
						 Jan 'Bulb' Hudec <bulb at ucw.cz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050920/2238047f/attachment.pgp 


More information about the bazaar mailing list