[PATCH] tests for remotebranch
Lalo Martins
lalo at exoweb.net
Wed Sep 14 23:12:41 BST 2005
And so says Robert Collins on 15/09/05 02:08...
> I'm merged this into integration, but would appreciate a follow up patch
> to correct the following quirks:
>
> PEP8 - the file names should all be lower case :).
>
> we shouldn't be using super in TestCase classes, as the top does not use
> super.
Yeah well, in my defense:
Two good reasons to break a particular rule:
(2) To be consistent with surrounding code that also breaks it
(maybe for historic reasons)
:-D
But sure, I can write a patch that fixes both my additions and the
existing code:
- I named the new module HTTPTestUtil because we already have a TestUtil
- and the TestCaseInTempDir class, from which mine inherits, uses super
(in fact, in the same methods as mine does). Personally, I don't even
like super, not the way it's implemented now.
best,
Lalo Martins
--
So many of our dreams at first seem impossible,
then they seem improbable, and then, when we
summon the will, they soon become inevitable.
--
http://www.exoweb.net/ mailto:lalo at exoweb.net
GNU: never give up freedom http://www.gnu.org/
More information about the bazaar
mailing list