[BUG] bzr branch fails because RemoteBranch doesn't throw NoSuchRevision

Aaron Bentley aaron.bentley at utoronto.ca
Mon Sep 5 00:57:58 BST 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

Martin recently updated Branch to throw NoSuchRevision from get_revision
and get_revision_xml.  However, it appears that RemoteBranch wasn't updated.

I coded greedy_fetch assuming that all Branches would now throw
NoSuchRevision.  Then I updated Branch.update_revisions to use
greedy_fetch.  As a result, branch and pull will now fail if they
encounter missing ancestors on a remote branch.  Note that
http://bazaar-ng.org/bzr/bzr.dev/ currently has missing ancestors.

19:39 < nezzz> preparing to copy
               bzr: ERROR:
'mbp at sourcefrog.net-20050707075712-4784aa908809b905'
19:39 < nezzz>   at
/R/moe/data/src/bzr-dev/bzr.dev/bzrlib/remotebranch.py line
               182, in __getitem__()
19:39 < nezzz>   see ~/.bzr.log for debug information
19:39 < nezzz> KeyError:
'mbp at sourcefrog.net-20050707075712-4784aa908809b905'


I had already patched this behaviour when I implemented fetch-missing,
but didn't realize that branch and pull were also affected.

Please see http://panoramicfeedback.com/opensource/bzr.24/

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDG4oG0F+nu1YWqI0RAvBtAJoCD1MGH6grphE8xH+VxzVKY83T4ACeM86v
eCrI1rikonUoySKVK/iGBKg=
=RNk/
-----END PGP SIGNATURE-----




More information about the bazaar mailing list