updated test suite support

[Martin Pool]

On 8/29/05, Robert Collins <robertc at robertcollins.net> wrote:
> On Thu, 2005-08-25 at 22:11 -0400, Aaron Bentley wrote:
> > I'm not sure about those names.  InTempDir is a lot more obvious.  I'm
> > not sure why testing an ImmutableStore would be 'functional', but
> > testing some iterator behavior would not be.
> >
> > Aside from that, these changes look really good.
> 
> There are a couple of reasons that drove my naming. One is a convention
> from testing that unit tests do not deal with external resources - they
> only operate in memory and typically are extremely small and precise in
> nature. Tests that do more, particularly those that act on external
> resources, are often referred to as functional tests. 

That's true, but the word "functional" is already excessively overloaded.

> Another is that
> InTempDir could be anything - the only reason someone reading the code
> would realise that that is a TestCase is by chasing two levels of
> pointers - the source they are in -> selftest.py -> testsweet.py.
> Calling it TestCaseInTempDir would be ok with me. Note that its
> providing more than just chdiring now, it also provides the run-external
> process facility.

I'll change it to that then. 

-- 
Martin