[BUG][PATCH] bzr revno=679 fails testbzr

Martin Pool mbp at sourcefrog.net
Wed Jun 15 04:36:07 BST 2005


On 14 Jun 2005, John Arbash Meinel <john at arbash-meinel.com> wrote:
> I'm trying to run the latest bzr (revno=679), and I found it has a few
> problems.
> 
> First, selftest doesn't work, because it tests some modules without any
> tests. The attached patch removes them. But you could also just add
> tests to those modules.
> 
> Second, testbzr calls tick() before it calls update, which means that
> there is an exception, since last_msg/last_cnt/etc all did not exist.
> 
> So I just added them into the __init__ constructor.

Thanks.

> There is a third problem, where if you have an missing or unknown file
> in the working tree, some of the time "bzr status" will give an
> exception rather than properly reporting what is going on. I'm guessing
> it is an issue with the stat cache. (Which should be renamed, since
> statcache is a builtin python module).

I can't reproduce the problem or segfault on Linux.

It probably should be removed, but also we should change to PEP8's
recommendation of always spelling out bzrlib.statcache.

-- 
Martin




More information about the bazaar mailing list