[announce] bzrweb seems a bit finished

[Martin Pool]

On Wed, 2005-06-01 at 10:16 +0800, Chris McCormick wrote:
> On Tue, May 31, 2005 at 10:30:06AM -0500, John A Meinel wrote:
> > Chris McCormick wrote:
> > > On Sat, May 21, 2005 at 01:17:02PM -0500, John A Meinel wrote:
> > > 
> > >>selected version, to me a plain diff is the diff *for* this revision. I
> > >>suppose you could make them both diff vs something since we seem to have
> > >>mixed understanding of what a plain diff means.
> > > 
> > > 
> > > I've fixed this and a couple of other bugs, and merged Lalo's server +
> > > rst patches. Unfortunately it's broken against the latest pull of bzr.dev
> > > from Martin. I guess I'll get onto that.
> > 
> > I would still like to see the currently selected entry have a
> > [diff vs <prev>]. But generally it looks good.
> 
> You're right of course. I've fixed this.
> 

> Bzrweb is working against the latest bzr.dev as well, however I think
> there may be some issues with locking files not owned by the Apache
> user again because the lock_mode argument was removed from the Branch
> constructor. 

There are now lock_read() and lock_write() methods.  I would expect that
bzrweb wouldn't need to call either of them though, because it's
presumably only doing readonly access and the relevant branch methods
take and release locks as needed.

Locking currently has the bug that it always tries to open the file
read-write even if it only wants a read lock, which is presumably
causing the permissions problems.  I am going to change that now so that
readers only need filesystem read access, which should fix your
problems.

-- 
Martin