Rev 4582: Fix some small comment bugs. in http://bazaar.launchpad.net/~jameinel/bzr/1.18-sigbreak
John Arbash Meinel
john at arbash-meinel.com
Fri Jul 31 15:57:12 BST 2009
At http://bazaar.launchpad.net/~jameinel/bzr/1.18-sigbreak
------------------------------------------------------------
revno: 4582
revision-id: john at arbash-meinel.com-20090731145655-y034rdf2csnr8kxe
parent: john at arbash-meinel.com-20090731145210-mdb6gt75s1dqddx9
committer: John Arbash Meinel <john at arbash-meinel.com>
branch nick: 1.18-sigbreak
timestamp: Fri 2009-07-31 09:56:55 -0500
message:
Fix some small comment bugs.
-------------- next part --------------
=== modified file 'bzrlib/tests/blackbox/test_breakin.py'
--- a/bzrlib/tests/blackbox/test_breakin.py 2009-07-31 00:13:11 +0000
+++ b/bzrlib/tests/blackbox/test_breakin.py 2009-07-31 14:56:55 +0000
@@ -72,8 +72,8 @@
children of self)
2) Sending SIGBREAK to a process that shares the current console,
which can be in its own process group.
- So we have start_bzr_subprocess to create a new process group for the
- spawned process, and then we map
+ So we have start_bzr_subprocess create a new process group for the
+ spawned process (via a flag to Popen), and then we map
SIGQUIT to GenerateConsoleCtrlEvent(CTRL_BREAK_EVENT)
SIGKILL to TerminateProcess
"""
@@ -122,8 +122,6 @@
# Win32 doesn't support WNOHANG, so we just pass 0
opts = getattr(os, 'WNOHANG', 0)
try:
- # note: waitpid is different on win32, but this test only runs
- # on unix
# TODO: waitpid doesn't work well on windows, we might consider
# using WaitForSingleObject(proc._handle, TIMEOUT)
# instead. Most notably, the WNOHANG isn't allowed, so
More information about the bazaar-commits
mailing list