[apparmor] [PATCH] regression test: conditionaly run pivot_root domain, transitions

[John Johansen]

On 09/07/2017 06:37 AM, Christian Boltz wrote:
> Hello,
> 
> I know this is already in bzr, but I have some minor nitpicking 
> nevertheless ;-)
> 
> Am Mittwoch, 6. September 2017, 22:09:05 CEST schrieb John Johansen:
>> Update the tests to test whether the kernel and parser support domain
>> transitions on pivot_root.
> 
>> --- a/tests/regression/apparmor/pivot_root.sh
>> +++ b/tests/regression/apparmor/pivot_root.sh
> 
>> +if [ "$(kernel_features_istrue namespaces/pivot_root)" != "true" ] ; then
>> +    echo "     kernel does not support pivot_root domain transitions skipping tests ..."
> 
> This reads as "kernel does not support [...] tests" while it's probably 
> meant as "kernel does not support [...] transitions, therefore skipping 
> tests".
> 
> Please change "transitions skipping" to "transitions, skipping" or 
> "transitions - skipping" ;-)  (whatever you prefer)
> 
>> +elif [ "$(parser_supports 'pivot_root -> foo,')"  != "true" ] ; then
>> +    #pivot_root domain transitions not supported
>> +    echo "     parser does not support pivot root domain transitions skipping tests ..."
> 
> Same here.
> 
> Pre-Acked-by: Christian Boltz <apparmor at cboltz.de> - feel free to commit
> to bzr without sending a patch first.
> 
done r3704


> 
> Regards,
> 
> Christian Boltz
> 
> 
>