[apparmor] [PATCH] regression test: conditionaly run pivot_root domain, transitions

Christian Boltz apparmor at cboltz.de
Thu Sep 7 13:37:46 UTC 2017


I know this is already in bzr, but I have some minor nitpicking 
nevertheless ;-)

Am Mittwoch, 6. September 2017, 22:09:05 CEST schrieb John Johansen:
> Update the tests to test whether the kernel and parser support domain
> transitions on pivot_root.

> --- a/tests/regression/apparmor/pivot_root.sh
> +++ b/tests/regression/apparmor/pivot_root.sh

> +if [ "$(kernel_features_istrue namespaces/pivot_root)" != "true" ] ; then
> +    echo "     kernel does not support pivot_root domain transitions skipping tests ..."

This reads as "kernel does not support [...] tests" while it's probably 
meant as "kernel does not support [...] transitions, therefore skipping 

Please change "transitions skipping" to "transitions, skipping" or 
"transitions - skipping" ;-)  (whatever you prefer)

> +elif [ "$(parser_supports 'pivot_root -> foo,')"  != "true" ] ; then
> +    #pivot_root domain transitions not supported
> +    echo "     parser does not support pivot root domain transitions skipping tests ..."

Same here.

Pre-Acked-by: Christian Boltz <apparmor at cboltz.de> - feel free to commit
to bzr without sending a patch first.


Christian Boltz
alles drumherum ist Schrott... Natürlich nur, wenn Du nicht wieder eine
deiner revolutionären Ideen hast. :-) Vielleicht eine chroot-Umgebung
pro compare-Prozess mit /tmp in einer initrd? :-))))
[Ratti in fontlinge-devel]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170907/49f88e33/attachment.sig>

More information about the AppArmor mailing list