[apparmor] [patch] Ignore test failures about duplicated conditionals in dbus rules

Tyler Hicks tyhicks at canonical.com
Mon May 8 15:09:28 UTC 2017


On 04/20/2017 02:23 PM, Tyler Hicks wrote:
> On 04/15/2017 05:54 PM, Christian Boltz wrote:
>> Am Samstag, 25. März 2017, 21:53:21 CEST schrieb Christian Boltz:
>>> since r3634, the tools allow any order of dbus conditionals.
>>>
>>> Quoting the r3634 patch description:
>>>
>>>   This patch eases the restriction on the ordering at the expense of
>>> the utils no longer being able to detect and reject a single
>>> attribute that is repeated multiple times. In that situation, only
>>> the last occurrence of the attribute will be honored by the utils.
>>>
>>> It seems nobody tested with all test profiles generated ;-) so we have
>>> to add some exceptions to the "does not raise an exception" list now.
> 
> There was a typo in my build/test script that caused these tests to be
> missed. I've just fixed my script.
> 
> Is there a good reason for the utils `make check` target to pass even if
> all the parser test profiles haven't been generated? If there's no good
> reason, could you update the tests to fail in that situation? A make
> variable could be added to indicate this this condition should be
> ignored so that you can quickly iterate on utils changes without needing
> all of the generated profiles.

Hi - I thought I'd ping you again about this so that it isn't forgotten.
Thanks!

Tyler

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170508/1f3b41b4/attachment.pgp>


More information about the AppArmor mailing list