[apparmor] [PATCH] json support for logprof and genprof

Christian Boltz apparmor at cboltz.de
Wed Jun 14 12:33:24 UTC 2017


Hello,

Am Dienstag, 13. Juni 2017, 18:10:54 CEST schrieb Goldwyn Rodrigues:
> From: Goldwyn Rodrigues <rgoldwyn at suse.com>
> 
> Provides json support to tools in order to interact with other
> utilities such as Yast.
> 
> The JSON output is one per line, in order to differentiate between
> multiple records. Each JSON record has a "dialog" entry which defines
> the type of message passed. A response must contain the "dialog"
> entry. "info" message does not require a response.
> 
> "apparmor-json-version" added in order to identify the communication
> protocol version for future updates.
> 
> This is based on work done by Christian Boltz.
> 
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.com>
...
> Changes since v4:
>  - Comments spacing
>  - response error to print the entire JSON string received
>  - Make sure the control goes through, for validation of ans and
> selected.

Thanks for the updated patch!

I'd still like to see some tests, but nevertheless -

Acked-by: Christian Boltz <apparmor at cboltz.de>

Since this is based on a proof of concept patch I wrote a year ago [1], 
this partially means reviewing my own work. Therefore I'd like to see a 
second review.

If nobody objects until saturday, I'll commit to bzr trunk.


Regards,

Christian Boltz

[1] actually a year and two weeks - I wrote that patch at the openSUSE
    Conference 2016, and the openSUSE Conference 2017 was just two weeks
    ago
-- 
hospitalistische Gründe. Wer heilt, hat Recht.
[Tao te Puh in opensuse-de]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170614/3595b629/attachment.pgp>


More information about the AppArmor mailing list