[apparmor] [PATCH 8/8] utils: Set parser executable path according to USE_SYSTEM make variable

Seth Arnold seth.arnold at canonical.com
Thu Feb 9 20:08:29 UTC 2017


On Thu, Feb 09, 2017 at 10:18:01AM -0600, Tyler Hicks wrote:
> > This appears to suffer a similar problem:
> > 
> >> +        # Check __AA_PARSER, which may be set by the Makefile, to see if
> >> +        # we should use a non-default apparmor_parser path to verify
> >> +        # policy
> >> +        parser = os.getenv('__AA_PARSER')
> >> +        if parser:
> >> +            self.full_args.append('--parser=%s' % parser)
> >> +
> 
> I feel like this one behaves as intended. If __AA_PARSER is an empty
> string, the "if parser:" conditional is tests out to be false and
> self.full_args remains unchanged.

Ah, you're right. I should have tested first. :)

Acked-by: Seth Arnold <seth.arnold at canonical.com>

Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170209/9430fac4/attachment-0001.pgp>


More information about the AppArmor mailing list