[apparmor] [PATCH] aa-notify: update to use 'normal' urgency to accommodate gnome-shell

Christian Boltz apparmor at cboltz.de
Tue Apr 11 21:02:06 UTC 2017


Am Dienstag, 11. April 2017, 19:40:14 CEST schrieb Tyler Hicks:
> On 04/11/2017 12:31 PM, Jamie Strandboge wrote:
> > aa-notify currently calls notify-send with urgency of 'critical'. In
> > gnome-shell critical urgency notifications result in a notification
> > that must be explictly clicked to dismiss (ie, they don't time out)
> > and gnome-shell does not honor -- expire-time with (at least)
> > critical urgency. In other popular DEs critical urgency
> > notifications time out. This patch updates the urgency to 'normal'
> > to obtain intended behavior across DEs.
> > 
> > Signed-off-by: Jamie Strandboge <jamie at canonical.com>
> The libnotify documentation is of no help in determining what should
> be normal and what should be critical:
> https://developer.gnome.org/libnotify/0.7/NotifyNotification.html#Noti
> fyUrgency

It does explain it, but the description is not too useful. As always, 
defining what is normal and what is critical probably depends on the POV.

> I guess that means that we need to set the urgency according to how
> the popular DEs handle these notifications.
> Acked-by: Tyler Hicks <tyhicks at canonical.com>

I just tested (with manual notify-send calls) with latest KDE Plasma - 
it seems it doesn't care about critical vs. normal, both look and behave 
the same (including automatically hiding the message after some seconds) 

So if this patch helps to improve the situation in Gnome,
Acked-by: Christian Boltz <apparmor at cboltz.de>


Christian Boltz

PS: non-random sig ;-)
<suseROCKs> mrdocs,   this is California.  Define "normal"
[from #opensuse-project]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170411/8c6d5700/attachment.pgp>

More information about the AppArmor mailing list