[apparmor] [PATCH v2] json support for tools (logprof and genprof)
apparmor at cboltz.de
Mon Apr 3 22:36:04 UTC 2017
Am Montag, 3. April 2017, 17:37:45 CEST schrieb Goldwyn Rodrigues:
> This is getting more complicated than can be handled. Do you think
> converting UI module to an abstract class, and deriving JSONUI and
> TextUI will be a better option? Though it would need more work, it
> would simplify a lot of things, be more flexible to changes and would
> be more robust than the hackish way it is being performed now.
Come on - ui.py is easy and boring. If you think it is complicated, have
a look at aa.py ;-)
I'm not against changes inside ui.py, but I'd like to keep the
switch(es) inside that file so that aa-logprof, aa.py etc. don't need to
know much about the UI handling.
set_json_mode() is such a minimal solution. If a class-based ui.py would
still have a similar interface for its callers, I'm ok with the class-
Your v2 patch loooks nearly finished (my comments probably look scarier
than they are ;-) so it's easier and faster to adjust the things Seth
and I noticed than starting from scratch ;-)
Also note that ui.py lacks test coverage (only 11% covered, and those
11% are basically the "import" lines and the definition of global
variables. I don't need to tell you that this makes changes a bit ;-)
Personally, I'd prefer to spend some time on writing tests over
rewriting ui.py. Or take some time to rewrite ui.py _and_ write tests
for it ;-)
> Finally, is it a principle to not "reply to all" on the mailing list?
> While the mail does reach me, The ML filters move the mails to
> respctive folders.
We don't have an official rule ;-) Personally I'm not too keen on getting
duplicated mails, so replying only to the mailinglist is enough (except
if you don't know if someone is subscribed, of course)
The tendens seems to go towards not having a forum. Not realy a
surprise. It is as if you were asking what the best sport is at
a soccer club. ;-) [houghi in opensuse]
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: This is a digitally signed message part.
More information about the AppArmor