[apparmor] [PATCH] tests: Allow stacking tests to use system programs and libraries

Tyler Hicks tyhicks at canonical.com
Tue Mar 29 16:07:44 UTC 2016


On 2016-03-28 23:55:42, Steve Beattie wrote:
> On Fri, Mar 25, 2016 at 11:37:31AM -0500, Tyler Hicks wrote:
> > The stacking tests worked fine when using in-tree programs and libraries
> > but the tests unexpectedly failed when USE_SYSTEM=1 was specified. This
> > patch makes use of the addimage:$test argument to mkprofile.pl to
> > generate the correct file permissions needed to use the system binaries.
> > 
> > Signed-off-by: Tyler Hicks <tyhicks at canonical.com>
> 
> Acked-by: Steve Beattie <steve at nxnw.org>, thanks.
> 
> Though, looking at what/why you're trying to solve with this, it might
> make sense to extend mkprofile.pl and prologue.inc to support a
> profile=XXX option that doesn't have the strict restrictions on existing
> binaries that image= does.

Agreed. I've got a growing list of mkprofile.pl improvements that I need
to make. This one, support for policy namespaces, dbus rule support, etc.

I'll slowly chip away at those things to clean up the workarounds that
I've had to do in the tests.

Tyler

> 
> -- 
> Steve Beattie
> <sbeattie at ubuntu.com>
> http://NxNW.org/~steve/



> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160329/3228b912/attachment.pgp>


More information about the AppArmor mailing list