[apparmor] linux-4.5/security/apparmor/match.c:64: possible copying of uninit fields ?

David Binderman dcb314 at hotmail.com
Tue Mar 15 11:02:30 UTC 2016


Hello there,

[linux-4.5/security/apparmor/match.c:64]: (error) Uninitialized struct member: th.td_hilen
[linux-4.5/security/apparmor/match.c:64]: (error) Uninitialized struct member: th.td_data

Source code is

       *table = th;

It looks to me like local struct th has only been partly initialised.

Given that this is a secure module, maybe making sure all fields
of th are inited to something sensible, maybe by using a call memset
around line 45, might be a good idea.  


Regards

David Binderman
 		 	   		  


More information about the AppArmor mailing list