[apparmor] [patch] parser: fix uninitialized field in convert_aaregex_to_pcre() [resend]

[Steve Beattie]

On Mon, Jan 25, 2016 at 12:07:13PM -0800, Seth Arnold wrote:
> On Mon, Jan 25, 2016 at 11:47:09AM -0800, Steve Beattie wrote:
> > This is an unchanged resend of the patch from this thread:
> > https://lists.ubuntu.com/archives/apparmor/2015-August/008494.html
> > 
> > The first entry in the grouping_count array is never initialized to 0;
> > subsequent depths are. This patch fixes the issue.
> > 
> > [parser-fix_uninitialized_grouping_value.patch]
> > 
> > Signed-off-by: Steve Beattie <steve at nxnw.org>
> 
> Acked-by: Seth Arnold <seth.arnold at canonical.com>
> 
> (slighly suggested to memset the whole thing to zero, or maybe assign the
> whole thing to zero:  int grouping_count[MAX_ALT_DEPTH] = {0}; -- but
> this alone is better than current. :)

Yes, much better suggestion, thanks. I'll incorporate that into the
commit.


-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160125/91a7638f/attachment.pgp>