[apparmor] [PATCH] Fix: parser: incorrect output of child profile names

Seth Arnold seth.arnold at canonical.com
Mon Apr 18 19:59:50 UTC 2016


On Mon, Apr 18, 2016 at 12:52:36PM -0700, John Johansen wrote:
> BugLink: http://bugs.launchpad.net/bugs/1551950
> 
> The apparmor_parser is incorrectly outputting the names of child profiles
> and hats, by adding a : between the parent and the child profile name
> 
> Eg.
>   /usr/sbin/httpd{,2}-prefork
>   /usr/sbin/httpd{,2}-prefork://DEFAULT_URI
>   /usr/sbin/httpd{,2}-prefork://HANDLING_UNTRUSTED_INPUT
> 
> instead of what it should be
>   /usr/sbin/httpd{,2}-prefork
>   /usr/sbin/httpd{,2}-prefork//DEFAULT_URI
>   /usr/sbin/httpd{,2}-prefork//HANDLING_UNTRUSTED_INPUT
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>

Acked-by: Seth Arnold <seth.arnold at canonical.com>

Thanks

> ---
>  parser/profile.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/parser/profile.h b/parser/profile.h
> index 5adbbcf..7121c0a 100644
> --- a/parser/profile.h
> +++ b/parser/profile.h
> @@ -225,7 +225,7 @@ public:
>  	std::string fqname(void)
>  	{
>  		if (parent)
> -			return parent->fqname() + "://" + name;
> +			return parent->fqname() + "//" + name;
>  		else if (!ns)
>  			return hname();
>  		return ":" + std::string(ns) + "://" + hname();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160418/0c1ab781/attachment.pgp>


More information about the AppArmor mailing list