[apparmor] [patch] Re-enable check-logprof in profiles 'make check' target

[John Johansen]

On 10/20/2015 12:50 PM, Christian Boltz wrote:
> Hello,
> 
> from my patch archive: [1]
> 
> aa-logprof is able to parse all profiles, so there is no longer a
> reason to skip this test.
> 
What happens when I break this again with new language additions? :)

> This patch reverts r2097 and r2098 from 2013-01-02.
> 
> 

I believe 99-let-make-check-work-without-configfile.diff addresses
Steve's NAK. Correct?

On that condition
Acked-by: John Johansen <john.johansen at canonical.com>


> [ profiles-enable-check-logprof.diff ]
> 
> === modified file 'profiles/Makefile'
> --- profiles/Makefile   2015-01-23 23:52:09 +0000
> +++ profiles/Makefile   2015-06-14 22:41:37 +0000
> @@ -78,11 +78,8 @@
>  IGNORE_FILES=${EXTRAS_SOURCE}/README
>  CHECK_PROFILES=$(filter-out ${IGNORE_FILES} ${SUBDIRS}, $(wildcard 
> ${PROFILES_SOURCE}/*) $(wildcard ${EXTRAS_SOURCE}/*))
>  
> -# check-logprof is disabled here because it has not kept up with
> -# advances in the apparmor policy language. Re-enable when it is
> -# updated.
>  .PHONY: check
> -check: check-parser
> +check: check-parser check-logprof
>  
>  .PHONY: check-parser
>  check-parser:
> 
> 
> 
> 
> 
> Regards,
> 
> Christian Boltz
> 
> [1] I already sent this patch in June, and it got mixed feedback:
>     - Acked-by: Kshitij Gupta <kgupta8592 at gmail.com>
>     - from Steve: NACK, unless aa-logprof will run successfully without 
>       the existence of the configuration files in /etc/apparmor/, which 
>       it sadly currently does not do.
>