[apparmor] [patch] Add DESCRIPTION and EXRESULT to new simple_tests includes

Christian Boltz apparmor at cboltz.de
Mon Jul 13 19:18:10 UTC 2015


Am Montag, 13. Juli 2015 schrieb Steve Beattie:
> On Sat, Jul 11, 2015 at 05:54:53PM +0200, Christian Boltz wrote:
> > some of the include files added to simple_tests recently don't live
> > in one of the main include directories (includes/,
> > includes-preamble/ or include_tests/) which lets
> > test-parser-simple-tests.py fail because those files don't contain
> > 
> > Instead of adding more exceptions to test-parser-simple-tests.py,
> > this patch adds DESCRIPTION and EXRESULT to those include files.
> This actually indicates a difference in behavior in the parser simple
> test script, which only uses files name *.sd as test input (though
> obviously they can include files that don't match the pattern) and
> your test script.

I know ;-)

I prefer to read all files (with the exceptions listed in test-parser-
simple-tests.py) instead of only *.sd (which comes with the risk of 
missing a file in case of a typo in the filename).

Yes, that causes some side effects like the patch described above - but 
IMHO that's worth it.

BTW: we have the includes, includes-preamble and include_tests 
directories where you can "hide" your includes even from 
test-parser-simple-tests.py ;-)


Christian Boltz
[tgz Datei entpacken]           tar xzf <Archiv>
Für weitere Informationen lesen Sie bitte die Manpage oder Ihren Admin.
[Torsten Hallmann in suse-linux]

More information about the AppArmor mailing list