[apparmor] [patch] Raise AppArmorBug on unknown request_mask in logparser.py

[Christian Boltz]

Hello,

an unknown request_mask means something strange[tm] happened, so we
should raise AppArmorBug (which gives us a full backtrace) instead of
AppArmorException (which "just" prints an error message)


I propose this patch for trunk, 2.10 and 2.9.


[ 38-change-unknown-request-mask-to-AppArmorBug.diff ]

=== modified file ./utils/apparmor/logparser.py
--- utils/apparmor/logparser.py 2015-12-11 20:43:30.543265557 +0100
+++ utils/apparmor/logparser.py 2015-12-11 20:41:11.720074915 +0100
@@ -17,7 +17,7 @@
 import sys
 import time
 import LibAppArmor
-from apparmor.common import AppArmorException, open_file_read, DebugLogger
+from apparmor.common import AppArmorBug, AppArmorException, open_file_read, DebugLogger
 
 from apparmor.aamode import validate_log_mode, log_str_to_mode, hide_log_mode, AA_MAY_EXEC
 
@@ -304,13 +304,13 @@
             rmask = rmask.replace('c', 'w')
             rmask = rmask.replace('d', 'w')
             if not validate_log_mode(hide_log_mode(rmask)):
-                raise AppArmorException(_('Log contains unknown mode %s') % rmask)
+                raise AppArmorBug(_('Log contains unknown mode %s') % rmask)
 
             dmask = e['denied_mask']
             dmask = dmask.replace('c', 'w')
             dmask = dmask.replace('d', 'w')
             if not validate_log_mode(hide_log_mode(dmask)):
-                raise AppArmorException(_('Log contains unknown mode %s') % dmask)
+                raise AppArmorBug(_('Log contains unknown mode %s') % dmask)
 
             # convert rmask and dmask to mode arrays
             e['denied_mask'],  e['name2'] = log_str_to_mode(e['profile'], dmask, e['name2'])


Regards,

Christian Boltz
-- 
[Need tool to uncover Rootkits]
Our approach is not to let rootkits enter the system :)
[Marcus Meissner in https://bugzilla.novell.com/show_bug.cgi?id=199078]