[apparmor] [patch] Split logparser.py add_event_to_tree() into multiple functions

Christian Boltz apparmor at cboltz.de
Sun Aug 2 22:11:06 UTC 2015


Hello,

Am Montag, 3. August 2015 schrieb Kshitij Gupta:
> On Sat, Jul 18, 2015 at 2:23 AM, Christian Boltz wrote:
...
> > [ 77-split-logparser-add_event_to_tree.diff ]

> > --- utils/apparmor/logparser.py 2015-07-17 22:43:21.977879320 +0200
> > +++ ./utils/apparmor/logparser.py       2015-07-17
...
> > +    def map_log_type(self, type):
>
> "type" is a keyword in Python so using it/overriding it in this scope
> is not a good idea and we can probably avoid it. How about "log_type"
> instead?
> 
> I'm aware that "type" has been incorrectly used as a variable at other
> places, but two wrongs don't make a right ;-)

Good point. I'll change it to log_type before commiting (and wonder why 
python doesn't complain about redefining keywords ;-)


Regards,

Christian Boltz
-- 
Lass es mich so sagen: GUIs? Wir haben keine. Davon aber zwei.
[Ratti in suse-linux]




More information about the AppArmor mailing list