[apparmor] [patch] Split logparser.py add_event_to_tree() into multiple functions

[Kshitij Gupta]

On Mon, Aug 3, 2015 at 3:41 AM, Christian Boltz <apparmor at cboltz.de> wrote:

> Hello,
>
> Am Montag, 3. August 2015 schrieb Kshitij Gupta:
> > On Sat, Jul 18, 2015 at 2:23 AM, Christian Boltz wrote:
> ...
> > > [ 77-split-logparser-add_event_to_tree.diff ]
>
> > > --- utils/apparmor/logparser.py 2015-07-17 22:43:21.977879320 +0200
> > > +++ ./utils/apparmor/logparser.py       2015-07-17
> ...
> > > +    def map_log_type(self, type):
> >
> > "type" is a keyword in Python so using it/overriding it in this scope
> > is not a good idea and we can probably avoid it. How about "log_type"
> > instead?
> >
> > I'm aware that "type" has been incorrectly used as a variable at other
> > places, but two wrongs don't make a right ;-)
>
> Good point. I'll change it to log_type before commiting (and wonder why
> python doesn't complain about redefining keywords ;-)
>
> pylint probably does complain about redefining keywords I think.

>
> Regards,
>
> Christian Boltz
> --
> Lass es mich so sagen: GUIs? Wir haben keine. Davon aber zwei.
> [Ratti in suse-linux]
>
>
> --
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/apparmor
>



-- 
Regards,

Kshitij Gupta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150803/5912c535/attachment.html>