[apparmor] [patch] parser: make flags defintion consistent
John Johansen
john.johansen at canonical.com
Fri Sep 12 00:14:28 UTC 2014
On 09/11/2014 04:04 PM, Steve Beattie wrote:
> On Wed, Sep 03, 2014 at 12:30:18PM -0700, Steve Beattie wrote:
>> In profile.h, flagvals is declared to be class, but then in the Profile
>> class, the flags field declares it as a struct. This patch makes the
>> field declaration type consistent.
>>
>> Signed-off-by: Steve Beattie <steve at nxnw.org>
yep
Acked-by: John Johansen <john.johansen at canonical.com>
>> ---
>> parser/profile.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: b/parser/profile.h
>> ===================================================================
>> --- a/parser/profile.h
>> +++ b/parser/profile.h
>> @@ -128,7 +128,7 @@ public:
>>
>> Profile *parent;
>>
>> - struct flagvals flags;
>> + class flagvals flags;
>> struct capabilities caps;
>> struct network net;
>
> Actually, I think the correct stylistic fix is to not use the class
> keyword there, like so:
>
> Signed-off-by: Steve Beattie <steve at nxnw.org>
> ---
> parser/profile.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/parser/profile.h
> ===================================================================
> --- a/parser/profile.h
> +++ b/parser/profile.h
> @@ -128,7 +128,7 @@ public:
>
> Profile *parent;
>
> - struct flagvals flags;
> + flagvals flags;
> struct capabilities caps;
> struct network net;
>
>
>
>
>
More information about the AppArmor
mailing list