[apparmor] [patch] parser: make flags defintion consistent

Steve Beattie steve at nxnw.org
Thu Sep 11 23:04:37 UTC 2014


On Wed, Sep 03, 2014 at 12:30:18PM -0700, Steve Beattie wrote:
> In profile.h, flagvals is declared to be class, but then in the Profile
> class, the flags field declares it as a struct. This patch makes the
> field declaration type consistent.
> 
> Signed-off-by: Steve Beattie <steve at nxnw.org>
> ---
>  parser/profile.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/parser/profile.h
> ===================================================================
> --- a/parser/profile.h
> +++ b/parser/profile.h
> @@ -128,7 +128,7 @@ public:
>  
>  	Profile *parent;
>  
> -	struct flagvals flags;
> +	class flagvals flags;
>  	struct capabilities caps;
>  	struct network net;

Actually, I think the correct stylistic fix is to not use the class
keyword there, like so:

Signed-off-by: Steve Beattie <steve at nxnw.org>
---
 parser/profile.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/parser/profile.h
===================================================================
--- a/parser/profile.h
+++ b/parser/profile.h
@@ -128,7 +128,7 @@ public:
 
 	Profile *parent;
 
-	struct flagvals flags;
+	flagvals flags;
 	struct capabilities caps;
 	struct network net;
 


-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140911/bee3f5fe/attachment.pgp>


More information about the AppArmor mailing list