[apparmor] [patch] update dependencies for utils coverage
Tyler Hicks
tyhicks at canonical.com
Thu Nov 13 20:01:30 UTC 2014
On 2014-11-07 17:52:19, Christian Boltz wrote:
> Hello,
>
> now that the severity tests are part of make coverage, we should extend
> the dependencies to the files needed by test-severity.py.
>
> Another (easier) option would be to use
> .coverage: $(wildcard ../aa-* ../apparmor/*.py *)
>
> Opinions?
>
>
> === modified file 'utils/test/Makefile'
> --- utils/test/Makefile 2014-11-04 21:01:14 +0000
> +++ utils/test/Makefile 2014-11-07 16:49:10 +0000
> @@ -42,7 +42,9 @@
> check:
> export PYTHONPATH=.. ; $(foreach test, $(wildcard test-*.py), $(call pyalldo, $(test)))
>
> -.coverage: $(wildcard ../aa-* ../apparmor/*.py test-*.py)
> +# files needed by test-*.py:
> +# - test-severity.py: severity.db severity_broken.db
> +.coverage: $(wildcard ../aa-* ../apparmor/*.py test-*.py severity.db severity_broken.db)
> export PYTHONPATH=.. ; $(foreach test, $(wildcard test-*.py), $(PYTHON) -m coverage run --branch -p $(test); )
> $(PYTHON) -m coverage combine
Would it be cleaner to add a target for test-severity.py which lists
severity.db and severity_broken.db as prereqs? Future targets that need
to list test-severity.db (and also severity*.db) as a prereq would then
be able to reuse the test-severity.db target.
Tyler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20141113/527bb7e0/attachment.pgp>
More information about the AppArmor
mailing list