[apparmor] [patch 04/11] utils: two minor cleanups in aa.py

Seth Arnold seth.arnold at canonical.com
Thu Mar 6 06:28:30 UTC 2014


On Wed, Mar 05, 2014 at 05:44:38PM -0800, Steve Beattie wrote:
> This patch removes a debugging print statement accidentally left in,
> as well as a duplicated initialization to a variable, and moves the
> variable init closer to the declaration that the variable is a global
> (diff represents the latter a little oddly).
> 
> Signed-off-by: Steve Beattie <steve at nxnw.org>

Acked-by: Seth Arnold <seth.arnold at canonical.com>

Thanks

> ---
>  utils/apparmor/aa.py |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Index: b/utils/apparmor/aa.py
> ===================================================================
> --- a/utils/apparmor/aa.py
> +++ b/utils/apparmor/aa.py
> @@ -599,7 +599,6 @@ def get_profile_flags(filename, program)
>  
>  def change_profile_flags(filename, program, flag, set_flag):
>      old_flags = get_profile_flags(filename, program)
> -    print(old_flags)
>      newflags = []
>      if old_flags:
>          # Flags maybe white-space and/or , separated
> @@ -2221,13 +2220,12 @@ def do_logprof_pass(logmark='', passno=0
>  #    transitions = hasher()
>  #    seen = hasher()  # XXX global?
>      global log
> -    global existing_profiles
>      log = []
> +    global existing_profiles
>      global sev_db
>  #    aa = hasher()
>  #    profile_changes = hasher()
>  #     prelog = hasher()
> -    log = []
>  #     log_dict = hasher()
>  #     changed = dict()
>  #    skip = hasher()  # XXX global?
> 
> 
> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140305/edb2a555/attachment.pgp>


More information about the AppArmor mailing list