[apparmor] aa-mergeprof testing results/bugs

[Kshitij Gupta]

Hello,

On Jul 29, 2014 4:45 PM, "Christian Boltz" <apparmor at cboltz.de> wrote:
>
> Hello,
>
> While testing aa-mergeprof, I found some issues:
>
> - (F)inish does nothing
>

This was fixed for other tools(aa-genprof and aa-logprof) IIRC to provide
expected behavior right? Maybe some tweaking is needed to propogate the
same here.

> - args.dir is ununsed - see my other mail with a 90% patch
>
> - even when (I)gnore'ing all changes, mergeprof asks to save the profile
>   (and behaves like cleanprof)
>

Hmm.. Probably a simple check if the profile was modified or not should
suffice for unmodified profiles and Ignore use cases.

> - aa-mergeprof sometimes crashes when saving the profile, but I don't
>   have a clear reproducer yet.
>

Do the crash happen when trying to save unmodified profiles only or also
when the profile is modified?

Regards,

Kshitij Gupta

> Backtrace:
>
> The following local profiles were changed. Would you like to save them?
>
> (S)ave Changes / [(V)iew Changes] / Abo(r)t
>    [... pressed "s"...]
> Aktualisiertes Profil für /usr/bin/maildrop wird geschrieben.
> Traceback (most recent call last):
>   File "../../utils/aa-mergeprof", line 695, in <module>
>     main()
>   File "../../utils/aa-mergeprof", line 79, in main
>     apparmor.aa.write_profile_ui_feedback(program)
>   File "/home/cb/apparmor/HEAD-CLEAN/utils/apparmor/aa.py", line 4325,
> in write_profile_ui_feedback
>     write_profile(profile)
>   File "/home/cb/apparmor/HEAD-CLEAN/utils/apparmor/aa.py", line 4351,
> in write_profile
>     changed.pop(profile)
> KeyError: '/usr/bin/maildrop'
>
>
> Regards,
>
> Christian Boltz
> --
> [makeSUSEdvd] When it works, I will most likely hold a press conference
> or something, so people will be informed by CNN. :-)
> [houghi in opensuse]
>
>
> --
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/apparmor
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140730/f3ad3882/attachment.html>