[apparmor] [patch 05/18] parser: remove unneeded e_buffer_overflow [resend]

John Johansen john.johansen at canonical.com
Fri Jan 24 10:37:56 UTC 2014


On 01/16/2014 02:06 PM, Steve Beattie wrote:
> As noted by Seth Arnold, e_buffer_overflow is no longer set in
> convert_aaregex_to_pcre(), so remove it and the sole check for it.
> 
> Signed-off-by: Steve Beattie <steve at nxnw.org>

Acked-by: John Johansen <john.johansen at canonical.com>

> ---
>  parser/parser_regex.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> Index: b/parser/parser_regex.c
> ===================================================================
> --- a/parser/parser_regex.c
> +++ b/parser/parser_regex.c
> @@ -42,7 +42,6 @@
>  enum error_type {
>  	e_no_error,
>  	e_parse_error,
> -	e_buffer_overflow
>  };
>  
>  /* Filters out multiple slashes (except if the first two are slashes,
> @@ -377,11 +376,6 @@ static pattern_t convert_aaregex_to_pcre
>  	}
>  	/* check error  again, as above STORE may have set it */
>  	if (error != e_no_error) {
> -		if (error == e_buffer_overflow) {
> -			PERROR(_("%s: Internal buffer overflow detected, %d characters exceeded\n"),
> -			       progname, PATH_MAX);
> -		}
> -
>  		PERROR(_("%s: Unable to parse input line '%s'\n"),
>  		       progname, aare);
>  
> 
> 
> -- AppArmor mailing list AppArmor at lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
> 




More information about the AppArmor mailing list