[apparmor] [patch] Fix dfa minimization

Steve Beattie steve at nxnw.org
Fri Jan 3 22:49:10 UTC 2014


On Tue, Dec 24, 2013 at 01:05:47PM -0800, John Johansen wrote:
> On 12/24/2013 09:06 AM, Tyler Hicks wrote:
> > I have to admit to not being very familiar with this area of the parser.
> > The changes look sane to me, but I don't really understand everything
> > that is going on.
> > 
> right, I am going to hold off on committing this until I have a few
> more tests to help verify every thing

For the record, this causes a failure in the regression tests, in the
query_label test, due to generating a profile that the kernel won't
accept. Specifically, the following profile fails to load:

  /home/ubuntu/bzr/apparmor/tests/regression/apparmor/query_label {
    file,
    audit deny dbus,
  }

Initial examination indicates that the patch is messing up the binary
blob element alignments for some unknown reason; it may be triggering
a latent bug in the parser.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140103/62fafc58/attachment-0001.pgp>


More information about the AppArmor mailing list