[apparmor] Please review and merge updated Pidgin profile [Was: Updating the Pidgin profile]

[Simon Deziel]

Hi intrigeri,

On 14-02-09 06:46 AM, intrigeri wrote:
>> * removed abstractions/dconf (does not exist as you said)
>> * added ~/.config/dconf/user
> 
> OK, I'm ignoring these backporting changes.

I don't understand why you ignored those. They are needed (both the
removal and the addition).

I also noticed you added "k" to "owner /{,var/}run/user/*/dconf/user".
Not needed here but I see no problem with it if you can confirm it's needed.

>> * dropped /{,var/}run/ compat (not needed anymore I think)
> 
> I'd like to keep the profile working on older distros, so I think I'll
> keep the compat stuff for now.

OK, I'll do the same to avoid diverging from the reference. FYI, the
profile you attached is missing the /var compat bits for the 2 last /run
rules.

> * In commit 03e6e407, you've added "#include
>   <abstractions/ubuntu-helpers>" and various other stuff, because
>   "abstractions/ubuntu-helpers is needed for the sanitized_helper".
>   I'm fine with the abstraction,

It seems like you omit to include this abstraction in your attached profile.

>   *but* most of the other stuff is
>   covered by the freedesktop.org abstraction, that is included by the
>   gnome one, that is in turn included by the Pidgin profile. So I'm
>   not merging this as is right now. Do you want to clean up this a bit
>   and remove the added duplicate lines?

I could remove some of them but had to keep the following as Pidgin
wants them:

owner @{HOME}/.local/share/applications/ r,
/usr/share/gnome/applications/ r,

> * Compared to the dconf abstraction, you're adding 'w' to "owner
>   @{HOME}/.config/dconf/user". Is it really needed? (Not for
>   me, apparently.)
> 
> * Compared to the dconf abstraction, you're adding 'w' to
>   "/run/user/[0-9]*/dconf/user". Is it really needed? (Not for
>   me, apparently.)

The "w" doesn't seem to be needed by Pidgin (I took it from another
profile using dconf but who needed it). I removed them.

> I'm glad we're converging on something that works for both of us! :)

I just pushed to github so you can diff against it, we now have very few
differences and I'd like to get to 0 :)

I've tested my version of the profile on Ubuntu 14.04 and Pidgin 2.10.9
so please let me know what you think of it.

Regards,
Simon