[apparmor] Please review and merge updated Pidgin profile [Was: Updating the Pidgin profile]

intrigeri intrigeri at debian.org
Sun Feb 9 11:46:42 UTC 2014


Hi Simon,

Simon Deziel wrote (28 Jan 2014 02:43:17 GMT) :
> So I went ahead and installed 14.04 and tried your profile. I made some
> changes:

> * removed abstractions/dconf (does not exist as you said)
> * added ~/.config/dconf/user

OK, I'm ignoring these backporting changes.

> * dropped /{,var/}run/ compat (not needed anymore I think)

I'd like to keep the profile working on older distros, so I think I'll
keep the compat stuff for now.

> * re-added ~/.config/indicators/ (my previous problem is corrected so
>                                   the blacklisting behaviour is fine
>                                   and depends on the libnotify plugin)

OK, added to my profile (attached).

> * added /run/user/[0-9]*/orcexec.* rw, (sound notifications again)

I've added the two lines seen in the lastest version of your profile,
then:

  owner /run/user/[0-9]*/ r,
  owner /run/user/[0-9]*/orcexec.* mrw,

I see other changes in your profile:

* In commit 03e6e407, you've added "#include
  <abstractions/ubuntu-helpers>" and various other stuff, because
  "abstractions/ubuntu-helpers is needed for the sanitized_helper".
  I'm fine with the abstraction, *but* most of the other stuff is
  covered by the freedesktop.org abstraction, that is included by the
  gnome one, that is in turn included by the Pidgin profile. So I'm
  not merging this as is right now. Do you want to clean up this a bit
  and remove the added duplicate lines?

* Compared to the dconf abstraction, you're adding 'w' to "owner
  @{HOME}/.config/dconf/user". Is it really needed? (Not for
  me, apparently.)

* Compared to the dconf abstraction, you're adding 'w' to
  "/run/user/[0-9]*/dconf/user". Is it really needed? (Not for
  me, apparently.)

I'm glad we're converging on something that works for both of us! :)

Regards
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: usr.bin.pidgin
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140209/42ba32d5/attachment.ksh>


More information about the AppArmor mailing list