[apparmor] Wish list

[John Johansen]

On 12/21/2014 09:15 AM, Christian Boltz wrote:
> Dear Santa,
> 
> I have some AppArmor patches that nobody reviewed since some weeks.
> Since I hope and assume I wasn't too naughty in the last year [1], can I 
> please have some comments or even Acks under my christmas tree? ;-)
> 
Hehe, sorry December has been a uh interesting month, there has been a
lot of vacation time burning going on and that has piled up all kinds of
work.

> My pending patches are:
> [apparmor] [patch] rule class - split out common parts from is_covered() (Dec 19)
> [apparmor] [patch] delete unused functions check_include_syntax() and check_profile_syntax in aa.py (Dec 6)
> [apparmor] [patch] improve severity.py test coverage (Dec 6)
> [apparmor] [patch] update aa.py is_skippable_file() according to libapparmor (Dec 6)
sorry I have been avoiding the aa.py stuff, I am just not where I want to
be on it to feel comfortable acking larger changes but I promise to skim
what is there today

> [apparmor] [patch] update and cleanup usr.sbin.dovecot profile (Dec 3)
ack sent

> [apparmor] [patch] add some missing /run/dovecot/* to usr.lib.dovecot.imap{, -login} (Dec 3)
ack sent

> [apparmor] [patch] extra profiles: update mysqld profile (Dec 1)
ack sent

> 
> There are also some unanswered questions in the following old mails:
> Re: [apparmor] [patch] make coverage should fail if one of the tests fails (Dec 4)
answered

> Re: [apparmor] [patch] - performance again... small changes (Nov 29)
err, I thought this one was answered, with your ack to Peter's patch
and a commit to the bzr tree. Seth acked your patch and you acked Peters
which is enough, am I missing something?

> Re: [apparmor] [patch] aa.py: change_profile vs. changes_profile (Nov 29, with test patch)
your patch was acked by sbeattie, as for the followup bug I have
created https://bugs.launchpad.net/apparmor/+bug/1404893, hopefully
sbeattie still has his full test case to add to it

> Re: [apparmor] [patch] add tests for aamode.py (Nov 29)
through in my 2 cents

> 
> I'm also quite sure that Tyler would love to get some feedback for his
> [apparmor] [PATCH 0/31] Prepare to move cache loading functionality to libapparmor
> [apparmor] [PATCH 0/12] Move aa_{match, features, kernel_interface, policy_cache} APIs
> patch series ;-)
> 
Indeed, I am working on it but its taking longer than I would like and
I am trying to go through the entire series and let the end result
feedback into earlier patches in the review.

I promise I'll get the review out before tyler is back from vacation.

> 
> *SCNR*, thanks and merry X-mas!
> 
> Christian Boltz
> 
> PS: I know you are quite busy these days. Maybe one of the AppArmor 
>     developers can help you with the patch reviews?
> 
> PPS: non-random sig ;-)
> 
> [1] as a fallback, I hope you didn't see everything *g*
>