[apparmor] [patch 07/12] Move nodeset caching into expr-tree.h
John Johansen
john.johansen at canonical.com
Thu Aug 21 20:36:44 UTC 2014
On 08/20/2014 01:02 AM, Steve Beattie wrote:
> On Fri, Aug 15, 2014 at 12:20:42PM -0700, john.johansen at canonical.com wrote:
>> We need to rework permission type mapping to nodesets, which means we
>> need to move the nodeset computations earlier in the dfa creation
>> processes, instead of a post step of follow(), so move the nodeset
>> into expr-tree
>>
>> Signed-off-by: John Johansen <john.johansen at canonical.com>
> I think this is okay, Acked-by: Steve Beattie <steve at nxnw.org>
>
> A stylistic question for you: where do you draw the line between
> implementing in a header file and implementing in a .cc file?
>
Wait, there is a line?
Seriously its just not something I think about a lot. Generally
if the change is large or I am making it depend on some static
fns in the .cc, other wise its what ever was convenient at the time.
Feel free to call me on it, and request changes
More information about the AppArmor
mailing list