[apparmor] [patch 05/12] Make the af type protocol mappings available for use

[Seth Arnold]

On Fri, Aug 15, 2014 at 12:20:40PM -0700, john.johansen at canonical.com wrote:
> Signed-off-by: John Johansen <john.johansen at canonical.com>
> Acked-by: Seth Arnold <seth.arnold at canonical.com>

Missed previously, the prototype for this function was introduced in the
previous patch.

> +const struct network_tuple *net_find_mapping(const char *family,
> +					     const char *type,
> +					     const char *protocol)
>  {

>  
> +struct network_tuple {
> +	const char *family_name;
> +	unsigned int family;
> +	const char *type_name;
> +	unsigned int type;
> +	const char *protocol_name;
> +	unsigned int protocol;
> +};

It's not introduced with this patch but I wonder if this structure should
be re-ordered. On a 64-bit platform, will those pointers by aligned along
8-byte boundaries leaving 4-byte holes? My first impression is that this
stores 36 bytes of data in 48 bytes of struct on a 64-bit platform.

Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140815/fdc4fe6b/attachment.pgp>