[apparmor] GSoC - updated reviews

[Christian Boltz]

Hello,

I just reviewed all old reviews. The attached tar.gz contains everything 
that is still not fixed. (If you disagree with something, you can of 
course just tell me that I'm wrong ;-)

To make things more interesting, I added some small issues that are 
related to the old reviews ;-)

The attached review-r69 (I needed a filename ;-) contains another small 
bug - it's just a missing space, but causes invalid profiles ;-)


Regards,

Christian Boltz
-- 
Look at Debian... its stable, works on a variety of platforms.... and
development is racing along at the speed of a turtle with 3 broken legs.
[Joseph M. Gaffney in opensuse]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reviews.tar.gz
Type: application/x-compressed-tar
Size: 25058 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130922/1686cfd9/attachment-0001.bin>
-------------- next part --------------
# (not really related to r69, but I needed a filename ;-)


(apparmor/aa.py)
def write_path_rules(prof_data, depth, allow):
...           
            while user or other:
                ownerstr = ''
                tmpmode = 0
                tmpaudit = False
                if user - other:
                    # if no other mode set 
                    ownerstr = 'owner'

# causes broken profiles - should be 'owner ' (space added)

                    tmpmode = user - other
                    tmpaudit = user_audit
                    user = user - tmpmode
                else:
                    if user_audit - other_audit & user:
                        ownerstr = 'owner '