[apparmor] [PATCH 2/8] refactor parser prefix parsing to remove execess code

Tyler Hicks tyhicks at canonical.com
Thu Sep 12 19:48:30 UTC 2013


On 2013-09-12 12:40:47, Steve Beattie wrote:
> On Wed, Sep 11, 2013 at 01:47:41AM -0700, Tyler Hicks wrote:
> > From: John Johansen <john.johansen at canonical.com>
> > 
> > Signed-off-by: John Johansen <john.johansen at canonical.com>
> 
> Acked-by: Steve Beattie <steve at nxnw.org> as it's a nice cleanup as is,
> but Tyler, I noticed that in merging in against the dbus code already
> committed, you didn't make the same opt_prefix simplification for
> 'dbus_rule' as John did for e.g. 'mnt_rule' or 'capability'. One of
> us should probably do that (I can if you're busy with other things).

Oh, I should have mentioned that I haven't done anything with the
patches that don't have my signed-off-by on them. I fixed merge
conflicts and test failures only. If a patch didn't cause one of those
issues, I haven't had a chance to review it yet (I was just about to
start reviewing the other patches).

I will send out a patch for dbus_rule shortly.

Tyler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130912/4671c12d/attachment.pgp>


More information about the AppArmor mailing list