[apparmor] [PATCH 3/3] parser: Clean up file entry processing

Tyler Hicks tyhicks at canonical.com
Wed Sep 11 18:54:52 UTC 2013


On 2013-09-11 03:30:46, Steve Beattie wrote:
> On Wed, Sep 11, 2013 at 01:42:32AM -0700, Tyler Hicks wrote:
> > Removes an unnecessary variable, simplifies and unifies some of the loop
> > logic, and removes commented out code.
> > 
> > Signed-off-by: Tyler Hicks <tyhicks at canonical.com>
> 
> Acked-by: Steve Beattie <steve at nxnw.org>
> 
> Similar comment as last time, it might help to make clear what's
> happening to lift the merging code out into a relatively simple
> function of its own.

Good idea. I'm going to place the sorting and the merging sections into
two separate functions. But, I'd like to wait until the C++ patch set
and other pending patches on the list settle before doing that. I've
added it to my todo list.

Tyler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130911/c13931d2/attachment.pgp>


More information about the AppArmor mailing list