[apparmor] [patch 4/8] parser valgrind tests - fixup suppressions

Seth Arnold seth.arnold at canonical.com
Thu Nov 28 01:24:09 UTC 2013


On Wed, Oct 23, 2013 at 06:41:48PM -0700, Steve Beattie wrote:
> With the C++-ization of the parser, some functions were renamed or
> eliminated; this patch fixes the relevant valgrind false positive suppression
> pattern to match.
> 
> Signed-off-by: Steve Beattie <steve at nxnw.org>

Acked-by: Seth Arnold <seth.arnold at canonical.com>

Thanks, learning more about valgrind has been on my todo list for ages.
Well, it still is, but at least I learned about the supressions now. :)

> ---
>  parser/tst/valgrind_simple.py |   11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> Index: b/parser/tst/valgrind_simple.py
> ===================================================================
> --- a/parser/tst/valgrind_simple.py
> +++ b/parser/tst/valgrind_simple.py
> @@ -45,15 +45,10 @@ VALGRIND_SUPPRESSIONS = '''
>      valgrind-serialize_profile-obsessive-overreads
>      Memcheck:Addr4
>      fun:_Z*sd_serialize_profile*
> -    fun:_Z*sd_serialize_codomain*
> -    fun:_Z*load_codomain*
> -    fun:_Z*__load_flattened_hat*
>      ...
> -    fun:twalk
> -    fun:_Z*load_flattened_hats*
> -    fun:_Z*sd_serialize_codomain*
> -    fun:_Z*load_codomain*
> -    fun:_Z*__load_policy*
> +    fun:_Z*__sd_serialize_profile*
> +    fun:_Z*load_profile*
> +    fun:_Z*load_policy_list*
>  }'''
>  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20131127/e663c903/attachment.pgp>


More information about the AppArmor mailing list