[apparmor] [patch 3/3] libapparmor - enhance readability of binding checking message

Steve Beattie steve at nxnw.org
Mon Aug 19 23:37:44 UTC 2013


This patch makes the binding check messages a little more understandable
and coherent. The original messages looked like (for a perl binding only
build):

  checking Checking for Python... no
  checking Checking for perl... yes
  checking for perl... /usr/bin/perl

Note the duplicated 'checking Checking' and '[cC]hecking for perl'
statements. With the patch applied, the output looks like thus:

  checking whether python bindings are enabled... no
  checking whether perl bindings are enabled... yes
  checking for perl... /usr/bin/perl

This patch is for both trunk and 2.8.3, though less important for
the latter, but since the only difference between the trunk version
of configure.in and the 2.8 version is trunk commit 2106 (which I
would also like to see applied to the 2.8 branch), it would make
backporting any additional future changes slightly easier.

Signed-off-by: Steve Beattie <sbeattie at ubuntu.com>

---
 libraries/libapparmor/configure.in |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: b/libraries/libapparmor/configure.in
===================================================================
--- a/libraries/libapparmor/configure.in
+++ b/libraries/libapparmor/configure.in
@@ -17,7 +17,7 @@ AC_PATH_PROG([SWIG], [swig])
 sinclude(m4/ac_pod2man.m4)
 PROG_POD2MAN
 
-AC_MSG_CHECKING(Checking for Python)
+AC_MSG_CHECKING([whether python bindings are enabled])
 AC_ARG_WITH(python,
 [  --with-python           enable the python wrapper  [[default=no]]],
 [AC_MSG_RESULT($withval)], [AC_MSG_RESULT(no)])
@@ -30,7 +30,7 @@ if test "$with_python" = "yes"; then
    AM_PATH_PYTHON
 fi
 
-AC_MSG_CHECKING(Checking for perl)
+AC_MSG_CHECKING([whether perl bindings are enabled])
 AC_ARG_WITH(perl,
 [ --with-perl           enable the perl wrapper [[default=no]]],
 [AC_MSG_RESULT($withval)], [AC_MSG_RESULT(no)])
@@ -43,7 +43,7 @@ if test "$with_perl" = "yes"; then
 fi
 
 
-AC_MSG_CHECKING(Checking for ruby)
+AC_MSG_CHECKING([whether ruby bindings are enabled])
 AC_ARG_WITH(ruby,
 [ --with-ruby           enable the ruby wrapper [[default=no]]],
 [AC_MSG_RESULT($withval)], [AC_MSG_RESULT(no)])

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130819/2c8a745d/attachment.pgp>


More information about the AppArmor mailing list