[apparmor] [PATCH] Fix clone test on quantal arm omap-4

Steve Beattie steve at nxnw.org
Sat Oct 13 12:50:30 UTC 2012


On Fri, Oct 12, 2012 at 01:58:49PM -0700, John Johansen wrote:
> On 10/12/2012 01:36 PM, Kees Cook wrote:
> > How about using getpagesize() instead?
> > 
> We certainly could, but certainly isn't required for this test.
> 
> tbh I am not even sure why we are bothering with PAGE_SIZE at
> all, after all we are just allocating some space for the threads
> stack.  And for this case anything over a few hundred bytes should
> be sufficient.

I suspect (since my recollection of writing this testcase is lost
in the sands of time) that I was just trying to be conservative in
allocating a sufficiently sized stack for the child thread. I'm not
opposed to doing something differently here.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20121013/1a2706e1/attachment.pgp>


More information about the AppArmor mailing list