[apparmor] [PATCH] Fix clone test on quantal arm omap-4

John Johansen john.johansen at canonical.com
Fri Oct 12 20:58:49 UTC 2012


On 10/12/2012 01:36 PM, Kees Cook wrote:
> On Fri, Oct 12, 2012 at 01:32:30PM -0700, John Johansen wrote:
>> It turns out that PAGE_SIZE isn't defined on all architectures.
>>
>> This fixes a regression test failure happening on Ubuntu quantal
>> on the arm ti-omap4 architecture
>>
>> Signed-off-by: John Johansen <john.johansen at canonical.com>
> 
> How about using getpagesize() instead?
> 
We certainly could, but certainly isn't required for this test.

tbh I am not even sure why we are bothering with PAGE_SIZE at
all, after all we are just allocating some space for the threads
stack.  And for this case anything over a few hundred bytes should
be sufficient.




More information about the AppArmor mailing list