[apparmor] [patch 2/6] abstract out cap and net proto generation to common/Make.rules

Steve Beattie steve at nxnw.org
Thu Mar 22 18:42:30 UTC 2012


On Thu, Mar 22, 2012 at 11:36:04AM -0700, John Johansen wrote:
> On 03/22/2012 10:06 AM, Steve Beattie wrote:
> > This patch abstracts out the generation of the lists of capabilities
> > and network protocol names to the common Make.rules file that is
> > included in most locations in the build tree, to allow it to be
> > re-used in the utils/ tree and possibly elsewhere.
> > 
> > It provides the lists in both make variables and as make targets.
> > 
> > It also sorts the resulting lists, which causes it to output differently
> > than the before case. I did confirm that the results for the generated
> > files used in the parser build were the same after taking the sorting
> > into account.
> > 
> 
> Well I can wish that the ordering of af_names was the same to make the
> comparison easier but it looks good.  So

When testing, I compared output with the sort command removed and then
diff'ed the output to ensure that I was getting anything different. But
yes, comparing the output with the sort in place is more difficult,
alas.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20120322/69deb1b4/attachment.pgp>


More information about the AppArmor mailing list