[apparmor] [PATCH] split parser build into "arch" "indep" and "check"

[Steve Beattie]

On Fri, May 27, 2011 at 02:19:11PM -0700, Kees Cook wrote:
> In some cases, it is desirable to build the parser without building the
> binary portions (Hurd). This patch splits up the build targets so this is
> possible:
> 
> "main" becomes "arch"
> 
> "indep" is created and depends on "docs"
> po building is moved from "main" to "indep"
> 
> "all" has "tests" removed (standard build practices are to "make" then
> "make check" so I think "tests"/"check" should stay separate from "all").

On the one hand, I dislike this because I'm afraid people will skip
running the parser tests before submitting patches to the parser. On
the other hand, we've accumulated enough tests for the parser that it
interferes with the compile/debug cycle to run all the tests and this
will mitigate that (though you could work around it in its existing
state by doing 'make apparmor_parser').

> redundant chunk is removed (this exists twice in the Makefile):
> -.SILENT: check
> -check: tests
> 
> "install" is split into "install-indep" and "install-arch"
> 
> "install-arch" requires "arch" and only installs the binaries
> 
> "install-indep" requires "indep" and only install non-binaries

The other changes I'm okay with.

I guess in the end, ACK from me, though you should purge the "not
strictly necessary" comment from /README:

parser:
$ cd parser
$ make
$ make tests    # not strictly necessary as they are run during the
                # build by default
$ make install

Thanks.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20110527/f8564744/attachment.pgp>