[apparmor] Deprecation of #include

John Johansen john.johansen at canonical.com
Sat Mar 26 11:00:25 UTC 2011


On 03/26/2011 01:25 AM, Seth Arnold wrote:
> On Sat, Mar 26, 2011 at 1:19 AM, John Johansen
> <john.johansen at canonical.com> wrote:
>> I would like to deprecate #include in favor of using include.
>>
>> Eg.
>>  #include <foo>
>> becomes
>>  include <foo>
> 
> I mentioned before that I thought we should change to "include <foo>" when
> include processing is treated as a first-class citizen, rather than treated as
> a CPP-style preprocessor. If we can compile/syntax check the included files as
> individual units, then I whole heartedly agree. :) But if it is still CPP-style
> trickery, I'd like to keep the CPP-style naming, so that admins will have the
> right picture in their mind of the problems when it comes time to debug why
> adding a new #include, or re-ordering the #includes, blew up the profile
> parsing. If it looks like Java package imports, they'll assume it is that
> sophisticated. If it looks like CPP, they'll know it's a hack. A useful hack :)
> but a hack.
> 
Hrmm, I don't think we tend to use them currently as a cpp style hack, but with
them being handled in the lexer it is possible.  I am not opposed to pulling
the processing out of the lexer and making them first class citizens




More information about the AppArmor mailing list