[apparmor] [PATCH 5/6] Update change_hatv and change_hat_vargs prototypes to use long

[Seth Arnold]

On Thu, Feb 17, 2011 at 6:49 PM, John Johansen
<john.johansen at canonical.com> wrote:
> its not the number of hats thats changing (kernel side that is still caped at 16,
> and a single page of data.  Its the magic token

*sigh* :) sorry for misreading.

> Normally I would agree with you that we need to keep the abi, and
> provide a versioned compatible version of the function in the library.
> However change_hatv and change_hat_varags are rather new, and have
> no consumers at the moment, so I am willing to risk breaking the
> abi, so that we can get them to be the same as change_hat.

Agreed that they should be the same as change_hat; I hope anyone who
might have written applications with these calls would step up sooner
rather than later if redeployment is difficult.

> And two the functions were actually already defined with long, its
> just the apparmor.h prototypes that weren't (well I guess the swig
> prototypes as well but those just got added too).

Heh, nothing like inconsistency between declaration and definition to
give some funny bugs somewhere down the road.

Thanks John!